Fix AsyncTransport verify_ssl and proxy#1149
Merged
Merged
Conversation
Owner
|
Good point! Thanks! Everything else working correctly? |
Contributor
Author
|
@mvantellingen Yup! So far so good with async zeep after fixing this up. I'll keep you posted if I hit anything strange along the way. Is there any chance you could possibly cut a new prerelease build in PyPI? Right now I am just building the wheel off of my fork for testing, but being able to hit PyPI directly again would be great. |
Owner
|
Good to hear, I've just released 4.0.0. Hoping that this (partial) async implementation is easier to maintain :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion to using httpx for AsyncTransport brought with it a few bugs that make it unusable:
This fixes these by passing any verify_ssl or proxy settings into the client constructors, so that they persist across all interactions. In addition, timeout settings were also moved into the client.